After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705167 - dlna-renderes: fix build with GTK+ 3.9.10+
dlna-renderes: fix build with GTK+ 3.9.10+
Status: RESOLVED DUPLICATE of bug 705294
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-30 19:36 UTC by Dominique Leuenberger
Modified: 2013-08-01 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dlna-renderes: fix build with GTK+ 3.9.10+ (1.71 KB, patch)
2013-07-30 19:36 UTC, Dominique Leuenberger 		reviewed Details | Review

Description Dominique Leuenberger 2013-07-30 19:36:27 UTC 
Building gnome-photos 3.9.5 fails with GTK+ 3.9.10 due to renamed widget API.
Comment 1 Dominique Leuenberger 2013-07-30 19:36:29 UTC 
Created attachment 250504 [details] [review]
dlna-renderes: fix build with GTK+ 3.9.10+

With GTK+ commit 89ae352, the widget template APIs were renamed.
Comment 2 Debarshi Ray 2013-08-01 15:28:12 UTC 
Review of attachment 250504 [details] [review]:

So many clones of this bug!

::: src/photos-dlna-renderers-dialog.c
@@ +277,1 @@
   g_type_class_add_private (class, sizeof (PhotosDlnaRenderersDialogPrivate));

You should use G_DEFINE_TYPE_WITH_PRIVATE and get rid of the g_type_class_add_private.
Comment 3 Debarshi Ray 2013-08-01 15:28:50 UTC 
Lets go with mclasen's version of the patch because he took the time to explain the details on IRC.

*** This bug has been marked as a duplicate of bug 705294 ***