After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705139 - 'make check' fails
'make check' fails
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-30 12:29 UTC by Kjartan Maraas
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
More reliable means of checking if object was finalized (32.57 KB, patch)
2013-08-17 08:51 UTC, Stef Walter
committed Details | Review

Description Kjartan Maraas 2013-07-30 12:29:06 UTC
make check fails here because it doesn't find libm.so under /usr/lib64 or something like that. Tried changing the path in the test code, but it still failed.

  /gck/attributes/new-empty:                                           OK
  /gck/attributes/empty:                                               OK
  /gck/attributes/find_attributes:                                     OK
PASS: test-gck-attributes
TEST: test-gck-module... (pid=4201)
  /gck/module/initialize_async:                                        OK
  /gck/module/invalid_modules:                                         p11-kit: couldn't load module: /opt/gnome3/lib64/pkcs11/blah-blah-non-existant: /opt/gnome3/lib64/pkcs11/blah-blah-non-existant: cannot open shared object file: No such file or directory
p11-kit: couldn't load module: /usr/lib/libm.so: /usr/lib/libm.so: cannot open shared object file: No such file or directory
FAIL
GTester: last random seed: R02S0501612e6f69118546f8f370939496a7
make[4]: *** [test] Terminert
make[4]: Leaving directory `/home/kmaraas/src/gnome/gcr/gck/tests'
make[3]: *** [check-am] Error 2
make[3]: Leaving directory `/home/kmaraas/src/gnome/gcr/gck/tests'
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory `/home/kmaraas/src/gnome/gcr/gck'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/kmaraas/src/gnome/gcr/gck'
make: *** [check-recursive] Error 1
*** Error during phase check of gcr: ########## Error running make -j2 check *** [24/228]
Comment 1 Stef Walter 2013-08-12 11:33:35 UTC
Is there a special setting to get jhbuild to run 'make check'? I've tried
'jhbuild buildone --force libsecret' but it doesn't do make check.
Comment 2 Kjartan Maraas 2013-08-14 15:13:23 UTC
--check
Comment 3 Stef Walter 2013-08-17 08:51:01 UTC
Created attachment 251980 [details] [review]
More reliable means of checking if object was finalized

Don't try to use G_IS_OBJECT() to see if an object was finalized
as this segfaults in corner cases, even with our crafty check
for a pointer within our memory space.
Comment 4 Stef Walter 2013-08-17 08:51:29 UTC
Attachment 251980 [details] pushed as dd6aba8 - More reliable means of checking if object was finalized