GNOME Bugzilla – Bug 705089
Search box eats first character after collections click, clears selection
Last modified: 2014-06-29 16:52:19 UTC
Searching after opening packagekit is ok. But then click a collection- the contents show properly, but if you then click to search, the first character you type will disappear, and the selected collection will be cleared.
Created attachment 252878 [details] [review] patch Here'a a patch for the first character eating. It does not change the behaviour when text is entered in the search entry (the package group is deselected and, accordingly, the package list is emptied): looking at the code it seems to me it was the intended behaviour.
Review of attachment 252878 [details] [review]: Thanks for taking the time to work on a small bug, and sorry it took a while to get a review. This works fine, and looks fine except for a style nit. ::: src/gpk-application.c @@ +1767,3 @@ /* clear group selection if we have the tab */ + if (pk_bitfield_contain (priv->roles, PK_ROLE_ENUM_SEARCH_GROUP) && + gtk_entry_get_text_length(entry)>0) { Can you add a space in front of the opening parenthesis before entry, and one on both sides of the >
(In reply to comment #2) > Can you add a space in front of the opening parenthesis before entry, and one > on both sides of the > Really petty of me to ask you to fix something this trivial after so long a wait; I'm just going to fix and push.