GNOME Bugzilla – Bug 704930
Prevent matroskademux from potentially seeking a lot when the SEQUENTIAL scheduling flag is set
Last modified: 2013-07-29 13:18:10 UTC
Created attachment 250200 [details] [review] proposed patch Attached patch makes matroska go into push mode when upstream had the SEQUENTIAL scheduling flag set to prevent overly enthousiastic seeking.. This is a pretty heavy hammer though, as matroska doesn't necessarily need a lot of seeking if an index is present. But as i'm not very familiar with matroska this is simplest solution for now ;)
Some testing shows that this is probably a too heavy hammer for now.. Seeking in webm files isn't as smooth as it was before anymore, I guess becuase it doesn't download the index anymore ? (But i haven' t looked in detail).
Comment on attachment 250200 [details] [review] proposed patch I think it's better to just run in pull mode and disable the one or two places where it jumps in the bisection search mode.
Looking through the code, it seems to me that it will only fall back to bisection search if it can't find an index. So we have two options: 0) Keep the current code, if the user is streaming a file not really suitable for it then a lot of seeks will happen if the user wants to seek.. 1) Fail the seek and/or flag the file as not seekable when there is no index and we've got SEQUENTIAL scheduling mode. I'm not sure what's better here, i'm leaning towards 0.. Streaming files that are bad for streaming will result in a bad experience, news at 11 ?
I don't think we should disable seeking just because it's going to be slow. People will file bugs for that, and rightly so IMHO.
In that case, imho this bug is invalid.. As the behaviour from matroskademux looks correct (it don't do more seeks then necessary, although it can be a lot iff they're necessary)