After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704927 - queue2: forward the upstream scheduling flags
queue2: forward the upstream scheduling flags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.1.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 704933
 
 
Reported: 2013-07-26 13:21 UTC by Sjoerd Simons
Modified: 2013-08-27 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.14 KB, patch)
2013-07-26 13:21 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2013-07-26 13:21:24 UTC 
Created attachment 250197 [details] [review]
proposed patch

Current muxers can't know that they should avoid seeks if possible when queue2 is used as it only indicates the _SEEKABLE  scheduling flag. By letting queue2 by default forwards the upstream, and add _SEEKABLE if required we can ensure information about _SEQUENTIAL and _BANDWIDTH_LIMITED also reaches the demuxer so they can act on them.

Proposed patch attached. One thing i'm not entirely sure about is whether _SEEKABLE should be masked if we're not using a tmpfile (I would assume not, but worth another look i guess)
Comment 1 Sebastian Dröge (slomo) 2013-07-26 15:14:29 UTC 
Comment on attachment 250197 [details] [review]
proposed patch

Why should SEEKABLE be masked? queue2 does passthrough of seeks if necessary
Comment 2 Sjoerd Simons 2013-07-29 13:09:48 UTC 
commit 7f8fb3861ed15c6b858f1ec81f980944514722db
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Fri Jul 26 15:08:13 2013 +0200

    queue2: Forward the schedule query upstream
    
    When asked about the scheduling flags first check with upstream and
    simply add the _SEEKABLE flag when using a temporary file as storage.
    
    This enables the forwarding of _SEQUENTIAL and _BANDWIDTH_LIMITED from
    sources if needed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704927