After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704887 - file monitoring improvements
file monitoring improvements
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-07-25 18:35 UTC by Allison Karlitskaya (desrt)
Modified: 2013-10-03 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Allison Karlitskaya (desrt) 2013-07-25 18:35:42 UTC 
Two-purpose bug;

1) Stop abusing constructor() in the file monitors.

2) Add a convenient API whereby things inside of GIO can easily create monitors for local files that report to the GLib worker thread.  There are all kinds of things that we could potentially want to use this for: desktop file directories, /etc/mtab, /etc/fstab, /etc/localtime, "etc" ...



This is part of my work at cleaning up gdesktopappinfo and adding support for the desktop file index, so the patches can be found here:

  https://git.gnome.org/browse/glib/log/?h=wip/gdesktopappinfo


This bug is only for the file-monitor related ones though, not the gdesktopappinfo ones (which are not yet ready).
Comment 1 Matthias Clasen 2013-07-29 04:31:09 UTC 
I've looked over the file-monitor part of that branch. Looked good to me. As I said elsewhere, it would be fantastic if we had some test coverage for file monitors; that would make changes of this scale much easier to swallow.

The cleanup patches for GDesktopAppInfo look fine too