After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704756 - g-ir-scanner ignores valid doc-comments on windows
g-ir-scanner ignores valid doc-comments on windows
Status: RESOLVED DUPLICATE of bug 693531
Product: gobject-introspection
Classification: Platform
Component: general
2.36.x
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-07-23 16:18 UTC by Jan Kneschke
Modified: 2015-02-07 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jan Kneschke 2013-07-23 16:18:31 UTC
1. the giscanner/sourcescanner.py SourceScanner._parse() opens a 
   tempfile with open("w+") which will result in a "text-mode" 
   on windows, aka \r\n line-endings.

2. the giscanner/annotationparser.py AnnotationParser.parse_comment_block()
   splits the comment-block on '\n' and matches the comment-start against
   ...[^\S\r\n]*$ ... all-whitespace-without-\r-or-\n.

Each comment that was generated through the source-scanner will have \r\n as line-ending after the /**. With the .split('\n') each header will be

  /**\r

and will be ignored.

Either

* fix the regexes to allow a trailing \r or
* use .splitlines() instead of .split('\n')
Comment 1 Emmanuele Bassi (:ebassi) 2013-08-26 17:20:53 UTC
this issue is also tracked in bug 693531 as part of an overall effort to improve Windows support of g-i. it probably makes sense to duplicate this bug into that.

*** This bug has been marked as a duplicate of bug 693531 ***
Comment 2 André Klapper 2015-02-07 17:00:20 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]