After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704705 - use O_TMPFILE
use O_TMPFILE
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-next]
Depends on:
Blocks:
 
 
Reported: 2013-07-22 20:09 UTC by Christian Persch
Modified: 2014-04-06 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
stream: file: Use O_TMPFILE when available (4.92 KB, patch)
2013-09-29 19:24 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2013-07-22 20:09:20 UTC 
Could use O_TMPFILE to create our vtestream temp files.

We currently use g_file_open_tmp(), but I think with the limitations of O_TMPFILE that functions can't be switched over to always use O_TMPFILE. So we should wrap that with a function trying O_TMPFILE and only falling back (on old kernel, or !linux) to g_file_open_tmp().
Comment 1 Christian Persch 2013-09-29 19:24:41 UTC 
Created attachment 256037 [details] [review]
stream: file: Use O_TMPFILE when available
Comment 2 Behdad Esfahbod 2013-09-29 19:38:09 UTC 
Comment on attachment 256037 [details] [review]
stream: file: Use O_TMPFILE when available

Looks good.  Thanks!