After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704691 - input-selector: active pad not notified
input-selector: active pad not notified
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.1.2
Other Linux
: Normal normal
: 1.1.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-22 16:05 UTC by Arnaud Vrac
Modified: 2013-07-23 06:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
input-selector: fix missing pad activation notification (1.65 KB, patch)
2013-07-22 16:05 UTC, Arnaud Vrac
committed Details | Review

Description Arnaud Vrac 2013-07-22 16:05:27 UTC
Created attachment 249817 [details] [review]
input-selector: fix missing pad activation notification

A new active pad might not be notified in some cases, which results in the current track number not being set in playbin.

The active-pad notification is only sent in the chain and sink_event functions, and only when the buffer or event that triggered the active pad selection is from the newly activated pad. So in the other case the notification will never be sent.

For example:

<inputselector2:sink_1> received event stream-start event: ...
<inputselector2> Activating pad inputselector2:sink_0
<inputselector2:sink_0> received event stream-start event: ...
Comment 1 Sebastian Dröge (slomo) 2013-07-23 06:59:24 UTC
commit 9bc26c5f25b9a581c1add0c457f0646cb6e3c8cf
Author: Arnaud Vrac <avrac@freebox.fr>
Date:   Mon Jul 22 18:03:01 2013 +0200

    input-selector: Fix missing pad activation notification
    
    A new active pad might not be notified in some cases, which results
    in the current track number not being set in playbin.
    
    The active-pad notification is only sent in the chain and sink_event
    functions, and only when the buffer or event that triggered the active
    pad selection is from the newly activated pad. So in the other case
    the notification will never be sent.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704691