GNOME Bugzilla – Bug 704548
qtdemux: set proper caps for mpeg-1 audio
Last modified: 2013-07-19 12:27:11 UTC
Created attachment 249623 [details] [review] qtdemux: set proper caps for mpeg-1 audio qtdemux sets invalid caps for mpeg-1 audio, since it reuses the AAC caps created from the fourcc (mp4a) field: audio/mpeg, mpegversion=(int)1, framed=(boolean)true, stream-format=(string)raw, layer=(int)3, codec_data=(buffer)0990, rate=(int)48000, channels=(int)2 With the patch I now get: audio/mpeg, mpegversion=(int)1, parsed=(boolean)true, codec_data=(buffer)0990, rate=(int)48000, channels=(int)2 The layer is not set anymore, since it can also be layer 1 or 2. We can't know without parsing the elementary stream.
Created attachment 249624 [details] [review] qtdemux: nitpicking in esds parsing This patch just cleans up caps creation in the ESDS atom, I didn't want to merge this in the first patch.
commit 40ab78825c1fa8e6c09625dd4a33b8c812c3503d Author: Arnaud Vrac <avrac@freebox.fr> Date: Fri Jul 19 01:49:20 2013 +0200 qtdemux: nitpicking in esds parsing commit d0d25a5e1f889f818e9afdd9a88b4a8ddf559300 Author: Arnaud Vrac <avrac@freebox.fr> Date: Fri Jul 19 01:49:07 2013 +0200 qtdemux: set proper caps for mpeg-1 audio Remove AAC specific fields from mpeg-1 audio caps, remove assumption that the mpeg1 audio layer is 3, and set `parsed' field. https://bugzilla.gnome.org/show_bug.cgi?id=704548