GNOME Bugzilla – Bug 704336
More fixes for PopupMenu
Last modified: 2013-07-17 16:53:01 UTC
Some of these I missed before in the last patch due to last-minute changes. Others are yet more code cleanups.
Created attachment 249281 [details] [review] popupMenu: Fix parenting implementation I got confused between menus and menu items.
Created attachment 249282 [details] [review] popupMenu: Use the parent field for sensitivity chaining Instead of a signal mess.
Created attachment 249283 [details] [review] popupMenu: Fix closing submenus when clicking on the expander We need to make sure that we reset the opened submenu when we close the submenu, not trick the toplevel into thinking a closed submenu is the currently opened menu.
Created attachment 249284 [details] [review] popupMenu: Remove non-all-spanning versions of colspan in popup menus This simplifies the code considerably, and makes 'expand' behave as expected.
Review of attachment 249281 [details] [review]: Ok
Review of attachment 249282 [details] [review]: That's better.
Review of attachment 249283 [details] [review]: Ok
Review of attachment 249284 [details] [review]: So now "expand" means "span: -1" too?
Yes, effectively. I couldn't find anywhere where we didn't always use the two together. It's still not the greatest API. You'll see what I do for this when I land the aggregate menus.
Review of attachment 249284 [details] [review]: Ok then (I used expand with this meaning in the past too, so I like it)
Attachment 249281 [details] pushed as a4a6e7c - popupMenu: Fix parenting implementation Attachment 249282 [details] pushed as 5a5b3bf - popupMenu: Use the parent field for sensitivity chaining Attachment 249283 [details] pushed as a2b499c - popupMenu: Fix closing submenus when clicking on the expander Attachment 249284 [details] pushed as 126f0ed - popupMenu: Remove non-all-spanning versions of colspan in popup menus