GNOME Bugzilla – Bug 704265
st-scroll-view: properly check if the scrollbars are visible
Last modified: 2021-07-05 14:34:09 UTC
We don't set :visible on the scrollbars, but use booleans to track if they are visible. Thus check the booleans instead of the actor's properties when allocating the scrollbars.
Created attachment 249208 [details] [review] st-scroll-view: properly check if the scrollbars are visible
Created attachment 249210 [details] screenshot The patch fixes rendering issues when using a scrollview with a scrollbar in the shell overview and displaying the shell statusbar, as can be seen in the attached screenshot. It can easily be tested with something like: --- a/js/ui/dash.js +++ b/js/ui/dash.js @@ -402,10 +402,15 @@ const Dash = new Lang.Class({ this._labelShowing = false; this._container = new DashActor(); + this._scrollView = new St.ScrollView({ style_class: 'hfade' }); this._box = new St.BoxLayout({ vertical: true, clip_to_allocation: true }); this._box._delegate = this; - this._container.add_actor(this._box); + this._scrollView.set_width(100.0); + this._scrollView.set_height(300.0); + + this._scrollView.add_actor(this._box, { x_fill: false }); + this._container.add_actor(this._scrollView); this._showAppsIcon = new ShowAppsIcon(); this._showAppsIcon.childScale = 1;
Review of attachment 249208 [details] [review]: Looks good.
Thanks, pushed to master and gnome-3-8.
This seems wrong see https://bugzilla.gnome.org/show_bug.cgi?id=705664#c5 ... your bug seem to be caused by the fade effect somehow getting the positions wrong when the messagetray is up. Can you reproduce (with your patch reverted) and without using hfade?
(In reply to comment #5) > This seems wrong see https://bugzilla.gnome.org/show_bug.cgi?id=705664#c5 ... > your bug seem to be caused by the fade effect somehow getting the positions > wrong when the messagetray is up. That's the standard "clones and offscreen effects don't mix" issue.
(In reply to comment #5) > This seems wrong see https://bugzilla.gnome.org/show_bug.cgi?id=705664#c5 ... > your bug seem to be caused by the fade effect somehow getting the positions > wrong when the messagetray is up. Can you reproduce (with your patch reverted) > and without using hfade? It indeed happens with hfade but doesn't happen without it. I can't remember why I was using hfade, but it shouldn't happen anyway?
(In reply to comment #7) > (In reply to comment #5) > > This seems wrong see https://bugzilla.gnome.org/show_bug.cgi?id=705664#c5 ... > > your bug seem to be caused by the fade effect somehow getting the positions > > wrong when the messagetray is up. Can you reproduce (with your patch reverted) > > and without using hfade? > > It indeed happens with hfade but doesn't happen without it. I can't remember > why I was using hfade, but it shouldn't happen anyway? No it shouldn't happen but this is a known bug see comment 6 ..
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/ Thank you for your understanding and your help.