After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704253 - Track titles listed as "FALSE" in album
Track titles listed as "FALSE" in album
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
3.10
Depends on:
Blocks:
 
 
Reported: 2013-07-15 14:25 UTC by Allan Day
Modified: 2013-07-17 09:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (176.79 KB, image/png)
2013-07-15 14:25 UTC, Allan Day 		  Details
Attachment to the patch. (1.01 KB, patch)
2013-07-15 22:36 UTC, Sai Suman Prayaga 		committed Details | Review
corrected the track names and erroricon display (1.05 KB, patch)
2013-07-16 07:00 UTC, Vadim Rutkovsky 		needs-work Details | Review
Fix for undiscoverable urls. (1.01 KB, patch)
2013-07-16 18:46 UTC, Sai Suman Prayaga 		committed Details | Review
fix for undiscoverable urls. (1.06 KB, patch)
2013-07-17 09:20 UTC, Vadim Rutkovsky 		committed Details | Review

Description Allan Day 2013-07-15 14:25:38 UTC 
Created attachment 249203 [details]
screenshot

Some tracks are listed as being called "FALSE" in the album view (see attached screenshot). The same tracks have the correct titles in artist or song view.
Comment 1 Sai Suman Prayaga 2013-07-15 22:36:00 UTC 
Created attachment 249251 [details] [review]
Attachment to the patch.

The iter value being set was incorrect, fixed the iter value.
correct icon and name of the song are now being shown.
Comment 2 Vadim Rutkovsky 2013-07-16 07:00:50 UTC 
The following fix has been pushed:
beaa764 corrected the track names and erroricon display
Comment 3 Vadim Rutkovsky 2013-07-16 07:00:58 UTC 
Created attachment 249255 [details] [review]
corrected the track names and erroricon display

	deleted:    0001-fixed-the-height-of-the-headerbar.patch
Comment 4 Shivani Poddar 2013-07-16 18:36:45 UTC 
Review of attachment 249255 [details] [review]:

Still shows FALSE for songs with undiscovered url. http://img.ctrlv.in/img/51e54a458c81b.png
The updates patch can be found http://paste.ubuntu.com/5880998/
Comment 5 Sai Suman Prayaga 2013-07-16 18:46:05 UTC 
Created attachment 249314 [details] [review]
Fix for undiscoverable urls.
Comment 6 Shivani Poddar 2013-07-16 18:58:40 UTC 
Review of attachment 249314 [details] [review]:

works for me :)
Comment 7 Vadim Rutkovsky 2013-07-17 09:19:15 UTC 
The following fixes have been pushed:
77b9f96 fix for undiscoverable urls.
3db8f9c AlbumArtCache: don't drop requests on the floor on failure
Comment 8 Vadim Rutkovsky 2013-07-17 09:20:34 UTC 
Tested on undiscoverable URI, works correctly

The following fix has been pushed:
2fd334d fix for undiscoverable urls.
Comment 9 Vadim Rutkovsky 2013-07-17 09:20:41 UTC 
Created attachment 249372 [details] [review]
fix for undiscoverable urls.