GNOME Bugzilla – Bug 704186
Fix the look of back button and next button in history dialog
Last modified: 2013-07-17 16:43:02 UTC
The mockup (from bug #681772, comment #c30): https://bug681772.bugzilla-attachments.gnome.org/attachment.cgi?id=230518
Created attachment 249106 [details] [review] user-accounts: Fix the look of back button and next button in history dialog
Created attachment 249107 [details] History dialog - before
Created attachment 249108 [details] History dialog - after
Created attachment 249109 [details] [review] user-accounts: set back button and next button in history-dialog as none relief I think it's more beautiful (should ask the designer for this).
Created attachment 249110 [details] History dialog - after - none relief
Created attachment 249111 [details] History dialog - after - none relief
Created attachment 249146 [details] [review] user-accounts: Fix the look of back button and next button in history dialog move set a class style to .ui file.
Created attachment 249147 [details] [review] user-accounts: set back button and next button in history-dialog as none relief
Obviously better. You have my blessing.
Review of attachment 249146 [details] [review]: Thank you for your patches. ::: panels/user-accounts/data/history-dialog.ui @@ +167,3 @@ + <child> + <placeholder/> + </child> Please remove all these placeholders. ::: panels/user-accounts/um-history-dialog.c @@ +358,3 @@ + widget = get_widget (um, "next-image"); + g_object_set (widget, "icon_name", rtl ? "go-next-rtl-symbolic" : "go-next-symbolic", NULL); Isn't it better to use gtk_image_set_from_icon_name instead g_object_set? @@ +361,3 @@ + + widget = get_widget (um, "previous-image"); + g_object_set (widget, "icon_name", rtl ? "go-previous-rtl-symbolic" : "go-previous-symbolic", NULL); Same here...
Review of attachment 249147 [details] [review]: Please use shorter commit message (also in your previous patch): https://wiki.gnome.org/Git/CommitMessages It looks good otherwise.
Created attachment 249405 [details] [review] user-accounts: fix the look of the arrows in the history dialog the commit messages is good?
Review of attachment 249405 [details] [review]: It looks good to me.
Are the assigned screenshots real? Have you there logs without time? Could you file it as new bug please? To the new bug report please assign output of commands: last and (where 1000 replace by your uid): dbus-send --system --print-reply --dest=org.freedesktop.Accounts /org/freedesktop/Accounts/User1000 org.freedesktop.DBus.Properties.Get string:'org.freedesktop.Accounts.User' string:'LoginHistory'
Review of attachment 249405 [details] [review]: pushed as 55b212075fd7f1b6801592a5e65e3d8fbf332f01 - user-accounts: fix the look of the arrows in the history dialog
Review of attachment 249147 [details] [review]: aday rejected it.