GNOME Bugzilla – Bug 704087
GtkPlacesSidebar shouldn't open a bookmark when the activation is caused by clicking eject
Last modified: 2013-09-21 02:31:20 UTC
Created attachment 248999 [details] [review] places sidebar: don't open a bookmark when clicking eject Per the summary and bug 699183 filed against nautilus 3.8.x when the user activates a bookmark in the GtkPlacesSidebar by clicking the eject button we shouldn't open the bookmark as it's about to go away. Find attached a port of the patch from nautilus to gtk+
This is still valid and kinda silly, I see it all the time...
Thanks for catching this. I pushed your patch to master as commit 24751cb.
the bug still seems to affect nautilus in latest 3.9 here, note, so I'm not sure the patch is sufficient.
I tested this with gtk+ master and its own testfilechooser, not with Nautilus. I'm jhbuliding up to Nautilus now to test it there.
it may be just that I'm actually testing the sidebar and not nautilus per se: what I've been doing is switching to a Files window and clicking the 'eject' button in the sidebar of the Files window. on doing that, the stick is unmounted but nautilus also tries to open it, and throws an error. that's nautilus but it's also a sidebar :) so i don't know which of the two paths it really is.
Yes, it's Nautilus using GtkPlacesSidebar. I don't know why the behavior was different; maybe they load things in different async ways, and the "this row was deleted because something got unmounted" got to Nautilus later, or something. Anyway, I just pushed 1e5dde7ea to master - it seems to fix this.