After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704074 - eog-jobs.h includes non-installed header eog-uri-converter.h
eog-jobs.h includes non-installed header eog-uri-converter.h
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Windows
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-12 09:10 UTC by Dominique Leuenberger
Modified: 2013-07-20 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix it (891 bytes, patch)
2013-07-12 09:31 UTC, Dominique Leuenberger 		none Details | Review

Description Dominique Leuenberger 2013-07-12 09:10:54 UTC 
eog 3.9.1 (and trunk) re-factored eog-jobs system in
https://git.gnome.org/browse/eog/commit/src/eog-jobs.h?id=e5c7e101621e19e908a834ae33480c72365bd361

this added a "include <eog/eog-uri-converter.h>", but this header is listed as NOINST_H_FILES.

As a consequence, a simple #include <eog/eog-jobs.h> fails (exposes for example build failures of eog-plugins).
Comment 1 Dominique Leuenberger 2013-07-12 09:31:42 UTC 
Created attachment 248992 [details] [review]
Fix it
Comment 2 Felix Riemann 2013-07-20 18:32:50 UTC 
Thanks, I didn't get around to check the plugins build and didn't notice.
I also made the EogURIConvert public as I don't like to have G_GNUC_INTERNAL functions in public headers.

commit 9066f65e6cd8430080665e55e63e0b780d27ee23
Author: Felix Riemann <>
Date:   Sat Jul 20 20:16:35 2013 +0200

    EogURIConverter: Make object functions public
    
    As we install the header we also need to make the class public.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704074

commit 5f5cdfe0fad98089b0c54be92b386fc54268aae4
Author: Dominique Leuenberger <>
Date:   Fri Jul 12 11:16:35 2013 +0200

    install eog-uri-converter.h
    
    eog-jobs.h includes this header
    https://bugzilla.gnome.org/show_bug.cgi?id=704074
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.