After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703830 - build: distcheck fails trying to delete libfolks_telepathy_la_vala.stamp
build: distcheck fails trying to delete libfolks_telepathy_la_vala.stamp
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-08 23:28 UTC by Travis Reitter
Modified: 2013-08-02 09:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Refer to the stamp file in the builddir, not srcdir (1.65 KB, patch)
2013-07-08 23:30 UTC, Travis Reitter 		committed Details | Review

Description Travis Reitter 2013-07-08 23:28:12 UTC 
Distcheck fails now because make wants to remove $(srcdir)/libfolks_telepathy_la_vala.stamp and that's a build no-no (since it's, in theory, deleting a source file).
Comment 1 Travis Reitter 2013-07-08 23:30:58 UTC 
Created attachment 248679 [details] [review]
Refer to the stamp file in the builddir, not srcdir

Patch from branch:

http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo703830-fix-distcheck
Comment 2 Philip Withnall 2013-07-09 07:41:23 UTC 
Review of attachment 248679 [details] [review]:

That’s odd, because the magical Vala rules which automake generates definitely always specify the .stamp file as being in $(srcdir). I guess if this fixes the bug, though…
Comment 3 Philip Withnall 2013-08-02 09:20:20 UTC 
Comment on attachment 248679 [details] [review]
Refer to the stamp file in the builddir, not srcdir

It’s also odd because distcheck passes for me without this patch applied. I’ll leave it uncommitted for this release.
Comment 4 Philip Withnall 2013-08-02 09:26:49 UTC 
Comment on attachment 248679 [details] [review]
Refer to the stamp file in the builddir, not srcdir

…which would be because it’s actually been committed already as deefe3f9194aca19f1b4f98dc16a736ae7e79e0a.