After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703789 - gtk.immodules still referenced after switch to immodules.cache
gtk.immodules still referenced after switch to immodules.cache
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-07-08 13:37 UTC by Michael Biebl
Modified: 2013-07-28 21:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch v1 (1.39 KB, patch)
2013-07-24 10:29 UTC, Takuro Ashie 		rejected Details | Review

Description Michael Biebl 2013-07-08 13:37:22 UTC 
Version: 2.24.20

The name and location of the immodules cache file was changed in 2.24.20 [1] to bring it in line with what is used in gtk3

There are still references to the old location/name though:

demos/gtk-demo/main.c:      g_setenv ("GTK_IM_MODULE_FILE", "../../modules/input/gtk.immodules", TRUE);
gtk/gtkimmodule.c:       * location. The gtk.immodules file distributed in
gtk/gtkimcontext.c: * the configuration file <filename>gtk.immodules</filename> needs to be
gtk/Makefile.am:TEST_DEPS = $(DEPS) gtk.immodules
gtk+.spec.in:%{_sysconfdir}/gtk-2.0/gtk.immodules
gtk-zip.sh.in:etc/gtk-2.0/gtk.immodules
modules/input/Makefile.am:	  echo "$(top_builddir)/gtk/gtk-query-immodules-2.0 > $(DESTDIR)$(sysconfdir)/gtk-2.0/gtk.immodules" ; \
modules/input/Makefile.am:	  $(top_builddir)/gtk/gtk-query-immodules-2.0 > $(DESTDIR)$(sysconfdir)/gtk-2.0/gtk.immodules ; \
modules/input/Makefile.am:	  echo "*** Warning: gtk.immodules not built" ; \
modules/input/Makefile.am:	rm -f $(DESTDIR)$(sysconfdir)/gtk-2.0/gtk.immodules
modules/input/Makefile.am:gtk.immodules: Makefile.am $(module_LTLIBRARIES)
modules/input/Makefile.am:	$(top_builddir)/gtk/gtk-query-immodules-2.0 $(module_LTLIBRARIES) > gtk.immodules
modules/input/Makefile.am:CLEANFILES = gtk.immodules
modules/input/Makefile.am:all-local: gtk.immodules
tests/testdnd.c:      g_setenv ("GTK_IM_MODULE_FILE", "../modules/input/gtk.immodules", TRUE);
tests/testcombochange.c:      g_setenv ("GTK_IM_MODULE_FILE", "../modules/input/gtk.immodules", TRUE);
tests/testtext.c:      g_setenv ("GTK_IM_MODULE_FILE", "../modules/input/gtk.immodules", TRUE);
tests/testgtk.c:      g_setenv ("GTK_IM_MODULE_FILE", "../modules/input/gtk.immodules", TRUE);

[1]
https://git.gnome.org/browse/gtk+/commit/?h=gtk-2-24&id=c8849046860a9b17fa943247d85ddadb29262b48
Comment 1 Takuro Ashie 2013-07-24 10:29:04 UTC 
Created attachment 250014 [details] [review]
Patch v1

I also met this bug.

Here is the patch to fix it.
Comment 2 John Ralls 2013-07-28 21:04:20 UTC 
Comment on attachment 250014 [details] [review]
Patch v1

Patch was incomplete -- it only addressed the installation of immodules.cache rather than all of the remaining references to gtk.immodules. Worse, the uninstalled gtk-query-immodules sometimes creates an empty immodules.cache.
Comment 3 John Ralls 2013-07-28 21:06:47 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

Fixed with commit 12fe6a9a1ad65a46de63d619925bd1e5e7f1f9b4