After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703608 - Update ClutterWaylandSurface to use a resource instead of wl_buffer
Update ClutterWaylandSurface to use a resource instead of wl_buffer
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on: 703877
Blocks:
 
 
Reported: 2013-07-04 12:56 UTC by Neil Roberts
Modified: 2013-07-10 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update ClutterWaylandSurface to use a resource instead of wl_buffer (5.63 KB, patch)
2013-07-04 12:56 UTC, Neil Roberts 		committed Details | Review

Description Neil Roberts 2013-07-04 12:56:26 UTC 
The Wayland server API has changed so that wl_shm_buffer is no longer
a type of wl_buffer and wl_buffer will become an opaque type. This
changes ClutterWaylandSurface to accept resources for a wl_buffer
instead of directly taking the wl_buffer so that it can do different
things depending on whether the resource points to an SHM buffer or a
normal buffer. This matches similar changes to Cogl:

https://git.gnome.org/browse/cogl/commit/?id=9b35e1651ad0e46ed48989
Comment 1 Neil Roberts 2013-07-04 12:56:31 UTC 
Created attachment 248375 [details] [review]
Update ClutterWaylandSurface to use a resource instead of wl_buffer
Comment 2 Rob Bradford 2013-07-10 09:24:07 UTC 
Review of attachment 248375 [details] [review]:

LGTM.
Comment 3 Rob Bradford 2013-07-10 09:24:07 UTC 
Review of attachment 248375 [details] [review]:

LGTM.
Comment 4 Emmanuele Bassi (:ebassi) 2013-07-10 13:37:33 UTC 
Attachment 248375 [details] pushed as 6c66148 - Update ClutterWaylandSurface to use a resource instead of wl_buffer