Created attachment 248263 [details] [review]
add support for evilvte and terminator

When I uninstalled gnome-terminal switching to evilvte, a lightweight terminal emulator, nautilus-open-terminal stopped working, notifying me that xterm could not be found. Desktop entries that specify 'Terminal=true' also failed to run silently.

xterm is indeed not installed on my system, but evilvte supports the same '-e' switch that xterm uses to execute a given command. Users of the emulator terminator report the same problem.

Inspecting the code, I found that the issue lies with glib. Installed terminal emulators are searched using a trail-and-error-approach in the function prepend_terminal_to_vector in gio/gdesktopappinfo.c. The attached patch should fix this by also searching for terminator and evilvte executables with lowest priority.

Steps to reproduce:
1) Uninstall any other terminal emulator apart from evilvte or terminator.
2) Try to open a terminal anywhere using the nautilus-extension open-terminal.