After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703437 - GDBusConnection: be more careful with async GetAll
GDBusConnection: be more careful with async GetAll
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other All
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-07-02 03:36 UTC by Allison Karlitskaya (desrt)
Modified: 2013-07-02 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GDBusConnection: be more careful with async GetAll (5.46 KB, patch)
2013-07-02 03:36 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-07-02 03:36:28 UTC 
See patch for explanation.
Comment 1 Allison Karlitskaya (desrt) 2013-07-02 03:36:30 UTC 
Created attachment 248195 [details] [review]
GDBusConnection: be more careful with async GetAll

It's possible to get a org.freedesktop.Properties.GetAll call even if we
have no readable properties in the introspection, in which case we
should return the empty list in the usual way.

We should certainly _not_ be dispatching to the method call handler of
an interface which has no properties (since it will not be expecting
this).

Add a check to make sure that there is at least one readable property
before assuming that a NULL get_property handler implies that we want to
handle properties asynchronously.

Add a testcase that was failing before the change and works after it.
Comment 2 Allison Karlitskaya (desrt) 2013-07-02 03:37:22 UTC 
Fallout from bug 698375...
Comment 3 fakey 2013-07-02 04:03:37 UTC 
Review of attachment 248195 [details] [review]:

Confirmed that this fixes the issue and 'make check' passes.
Comment 4 Allison Karlitskaya (desrt) 2013-07-02 13:15:09 UTC 
Attachment 248195 [details] pushed as cb44696 - GDBusConnection: be more careful with async GetAll