GNOME Bugzilla – Bug 703396
Use totem-pl-parser instead of libquvi
Last modified: 2013-08-23 20:11:23 UTC
totem-pl-parser already supports parsing quvi-supported links to give back a full playback URL. Using totem-pl-parser means that: - we don't rely on libquvi directly - we don't need to port grilo-plugins for new libquvi versions (0.9 is out and the API is not compatible) - we avoid the licensing problems with libquvi (it being AGPLv3+ and incompatible with grilo's license, eg. grilo wouldn't be a full LGPLv2+ but "downgraded" to GPLv3+)
Definitely. Also, this task should be part of a bigger one: split the quvi part (now, totem-pl-parser) into its own plugin. Thus, we don't need to handle that code in each plugin; it will be only in one specific place (this new quvi/totem-pl-parser plugin). And moreover, for new plugins coming that needs quvi for getting some metadata values (like URL), the quvi/totem-pl-parser plugin will be already there, so they don't need to cope with those properties.
Created attachment 248577 [details] [review] youtube: Use totem-pl-parser to resolve URI Instead of libquvi directly.
Created attachment 248578 [details] [review] vimeo: Use totem-pl-parser to resolve URI Instead of libquvi directly.
Created attachment 248579 [details] [review] build: Remove unused libquvi check It's not used anymore.
commit 17ecdfc20e4df518c7f53260cadfe00f0f42965b Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jul 8 09:55:25 2013 +0200 build: Remove unused libquvi check It's not used anymore. https://bugzilla.gnome.org/show_bug.cgi?id=703396 configure.ac | 2 -- 1 file changed, 2 deletions(-) commit 00147fa6051afc8f6db2f8b9292858abc686062c Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jul 8 09:54:56 2013 +0200 vimeo: Use totem-pl-parser to resolve URI Instead of libquvi directly. https://bugzilla.gnome.org/show_bug.cgi?id=703396 configure.ac | 10 +++++----- src/vimeo/gvimeo.c | 86 +++++++++++++++++++++++--------------------------------------------------------------- 2 files changed, 28 insertions(+), 68 deletions(-) commit c03a80506c18c95cd44f4e38202ca62f1104578c Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jul 8 09:52:09 2013 +0200 youtube: Use totem-pl-parser to resolve URI Instead of libquvi directly. https://bugzilla.gnome.org/show_bug.cgi?id=703396 configure.ac | 10 +++++----- src/youtube/grl-youtube.c | 57 +++++++++++++++++++++++---------------------------------- 2 files changed, 28 insertions(+), 39 deletions(-)