Should be both consumer and producer of this meta

Created attachment 259780 [details] [review]
memory: provide copy_into_texture

Created attachment 259781 [details] [review]
mixer: provide access to the sink pads at render time

Created attachment 259782 [details] [review]
upload: add support for GstVideoGLTextureUploadMeta

Created attachment 259798 [details] [review]
upload: add support for GstVideoGLTextureUploadMeta

v2 that compiles

Created attachment 259959 [details] [review]
filter: handle capsfeatures properly

This allows negotiation to occur with the upload meta and thus the gl filters can be used with hw-decoded video.

Created attachment 259960 [details] [review]
mixer: handle 0/1 famerate better in caps

Apparently if a single zero framerate source is linked to glmixer, it complains about invalid caps.  Relax the restrictions a little bit.

Created attachment 259961 [details] [review]
mixer: advertise GstVideoGLTextureUploadMeta

Review of attachment 259798 [details] [review]:

::: gst-libs/gst/gl/gstglfilter.c
@@ +38,3 @@
+        GST_VIDEO_CAPS_MAKE_WITH_FEATURES
+        (GST_CAPS_FEATURE_META_GST_VIDEO_GL_TEXTURE_UPLOAD_META,
+            GST_GL_UPLOAD_FORMATS))

This is not correct as you only handle RGBA currently for the texture upload meta

::: gst-libs/gst/gl/gstglupload.c
@@ +579,3 @@
+  /* GstVideoGLTextureUploadMeta */
+  gl_tex_upload_meta = gst_buffer_get_video_gl_texture_upload_meta (buffer);
+  if (gl_tex_upload_meta) {

here you should also check the limitations of the meta support, i.e. one RGBA texture. And otherwise fall back to the normal code path

Review of attachment 259961 [details] [review]:

::: gst-libs/gst/gl/gstglmixer.c
@@ +517,3 @@
+        GST_VIDEO_CAPS_MAKE_WITH_FEATURES
+        (GST_CAPS_FEATURE_META_GST_VIDEO_GL_TEXTURE_UPLOAD_META,
+            GST_GL_UPLOAD_FORMATS))

You currently only handle RGBA here

Created attachment 264956 [details] [review]
upload: add support for GstVideoGLTextureUploadMeta

addresses previous issues

Comment on attachment 264956 [details] [review]
upload: add support for GstVideoGLTextureUploadMeta

All pushed