After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703239 - Please check the license of libcheese/um-crop-area.c
Please check the license of libcheese/um-crop-area.c
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
unspecified
Other Linux
: Normal major
: 3.8
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-28 11:41 UTC by Jeremy Bicha
Modified: 2013-06-30 07:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
um-crop-area.c: Relicense to GPLv2+ (1001 bytes, patch)
2013-06-30 01:41 UTC, Matthias Clasen
committed Details | Review

Description Jeremy Bicha 2013-06-28 11:41:00 UTC
Although cheese is released under the GPL-2+, there is one file that claims to be under the GPL-3+: libcheese/um-crop-area.c

When I looked at the git history of the file, I found bug 606730 which claims that the code came from Shotwell. Shotwell is released under the LGPL-2.1+. I also checked Shotwell 0.4 which was the current stable release at that time but it used the same license. Further, I did not find that file or code that looked similar to it in the Shotwell sources. (For one thing Shotwell has always been written in Vala.)

If the code indeed comes from Shotwell under the LGPL-2.1+ then it should be possible to relicense it under the GPL-2+.
https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility
Comment 1 Jeremy Bicha 2013-06-28 13:03:12 UTC
and libcheese/um-crop-area.h is GPL-2+
Comment 2 David King 2013-06-28 13:16:55 UTC
Hi Bastian, it looks like you added the problematic file(s) in question (in commit b4e2a01d723a8bdb74c6327d862e0ef1af9ba08a), although Matthias may have copied/written the code originally. Can you or Matthias investigate and confirm the licensing? If it is OK to put this code under GPL-2+ like the rest of Cheese, a patch to update the license would be great. Thanks.
Comment 3 Matthias Clasen 2013-06-30 01:41:38 UTC
Created attachment 248076 [details] [review]
um-crop-area.c: Relicense to GPLv2+

This makes the file fit in better with the rest of Cheese,
license-wise.
Comment 4 Matthias Clasen 2013-06-30 01:41:53 UTC
The code was inspired by the shotwell cropping tool, but I don't think it bears much resemblance to it now. In any case, relicensing it would be fine with me.
Comment 5 David King 2013-06-30 07:17:33 UTC
Comment on attachment 248076 [details] [review]
um-crop-area.c: Relicense to GPLv2+

Thanks for the clarification. I pushed this to master as commit 7aab154c74ee9a6487e38300d907bd797fd5ba0e.