After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703182 - multipartmux does not push new segment after flushing seek
multipartmux does not push new segment after flushing seek
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.1.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-27 11:31 UTC by Ognyan Tonchev (redstar_)
Modified: 2013-07-09 07:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
possible flag which resets the need_segment flag after flush_start (2.05 KB, patch)
2013-06-27 11:31 UTC, Ognyan Tonchev (redstar_) 		needs-work Details | Review
Updated to FLUSH_STOP (2.05 KB, patch)
2013-07-09 06:59 UTC, Ognyan Tonchev (redstar_) 		committed Details | Review

Description Ognyan Tonchev (redstar_) 2013-06-27 11:31:00 UTC 
Created attachment 247893 [details] [review]
possible flag which resets the need_segment flag after flush_start

Create a pipeline filesrc ! matroskademux ! multiqueue ! multipartmux ! fakesink
Pause, wait for preroll, seek. It results in:

gstreamer/gst/gstpad.c:3913:gst_pad_push_data:<multipartmux0:src> Got data flow before segment event
Comment 1 Sebastian Dröge (slomo) 2013-07-01 09:21:24 UTC 
Review of attachment 247893 [details] [review]:

::: gst/multipart/multipartmux.c
@@ +389,3 @@
+
+  switch (GST_EVENT_TYPE (event)) {
+    case GST_EVENT_FLUSH_START:

This should be FLUSH_STOP instead. Otherwise there's a small race condition possible
Comment 2 Ognyan Tonchev (redstar_) 2013-07-09 06:59:35 UTC 
Created attachment 248691 [details] [review]
Updated to FLUSH_STOP
Comment 3 Sebastian Dröge (slomo) 2013-07-09 07:17:15 UTC 
commit aa2d96c46bb4232eefe7ca57a07714639563e241
Author: Ognyan Tonchev <ognyan@axis.com>
Date:   Thu Jun 27 13:26:31 2013 +0200

    multipartmux: Re-set need_segment flag after FLUSH_STOP
    
    https://bugzilla.gnome.org/show_bug.cgi?id=703182