After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703043 - problematic column layout
problematic column layout
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Wacom
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Joaquim Rocha
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-25 10:46 UTC by Jakub Steiner
Modified: 2021-06-09 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wacom: Expand columns in buttons' assignment treeview (1.40 KB, patch)
2013-06-25 12:25 UTC, Joaquim Rocha
committed Details | Review
shortcut (48.13 KB, image/png)
2013-07-18 09:34 UTC, Bastien Nocera
  Details

Description Jakub Steiner 2013-06-25 10:46:34 UTC
The default layout doesn't give the last column enough room so when you are assigning the first "send keystroke", it's off screen and you have no indication the process was successful. Once you have some shortcuts assigned, it works fine. Unfortunately it is more critical to communicate well what's happening the first time.
Comment 1 Joaquim Rocha 2013-06-25 10:49:21 UTC
That's true. I have fixed it in the patch that puts the modifiers in that same tree view.

I'll extract the fix and put it here.
Comment 2 Joaquim Rocha 2013-06-25 12:25:40 UTC
Created attachment 247723 [details] [review]
wacom: Expand columns in buttons' assignment treeview

Because the GtkCellRendererAccel can't almost be seen.
Comment 3 Bastien Nocera 2013-07-16 15:34:46 UTC
Review of attachment 247723 [details] [review]:

Looks fine for gnome-3-8, we're replacing that code in master.
Can you make sure that this doesn't squash the key description though?
Comment 4 Joaquim Rocha 2013-07-17 13:52:53 UTC
Pushed.

commit 35e3697b1d34fb21f1b08b0ea410713f45286c0c
Comment 5 Bastien Nocera 2013-07-18 09:33:54 UTC
It's broken still...
Comment 6 Bastien Nocera 2013-07-18 09:34:38 UTC
Created attachment 249480 [details]
shortcut

The "New accelerator" message isn't getting expanded.
Comment 7 Joaquim Rocha 2013-07-18 11:06:55 UTC
It is set to expand. The problem is that, with some languages, the text gets to wide and something's got to give in, in this case is the edition mode of the accel renderer.

I don't think the original issue was to make everything visible but to rather be able to assign the first key shortcut when the renderer was being "pushed offscreen". I think that with the three expanding columns as it is now, one can easily press the accel and assign a key shortcut.
Comment 8 André Klapper 2021-06-09 16:06:25 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new bug report at
  https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/

Thank you for your understanding and your help.