After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702645 - DSCP QoS support
DSCP QoS support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
1.x
Other Linux
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-19 11:42 UTC by Alexander Schrab
Modified: 2014-02-25 22:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (3.70 KB, patch)
2013-06-24 08:49 UTC, Alexander Schrab 		none Details | Review

Description Alexander Schrab 2013-06-19 11:42:47 UTC 
We need to be able to set DSCP QoS on the udp sockets sending rtp data. The information is deduced from the URL and/or general settings in the rest of the application and need to be communicated and used in rtsp-stream.c when creating the multiudpsocket.

I don't have a full patch yet, but my idea is that we could communicate this information as metadata on the payloader elements.

g_object_set_data_full / g_object_get_data

If this sounds acceptable I will create a patch for review. If not, then I would appriciate a pointer on how stream-specific data like this should be communicated.
Comment 1 Wim Taymans 2013-06-20 13:49:03 UTC 
It sounds like another option to configure on the rtsp-stream object. We currently configure the MTU (on the stream payloader).

So, it looks like we want another gst_rtsp_stream_set_qos_dscp() and then some vmethod to configure the stream.
Comment 2 Alexander Schrab 2013-06-24 06:19:03 UTC 
Would it be ok to configure the stream in the new_stream signal handler? At that point I don't think the udpsink exists yet, but that could be easily handled.
Comment 3 Alexander Schrab 2013-06-24 08:49:18 UTC 
Created attachment 247602 [details] [review]
Patch
Comment 4 Wim Taymans 2013-06-24 13:08:53 UTC 
commit c3f867317494ccd38e8bbc76f5235e2287b846b3
Author: Alexander Schrab <alexas@axis.com>
Date:   Mon Jun 24 10:43:59 2013 +0200

    dscp qos support in gst-rtsp-stream
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=702645