After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702538 - images drawn with wrong offset
images drawn with wrong offset
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal blocker
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2013-06-18 09:03 UTC by Vidar Braut Haarr
Modified: 2013-06-18 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vidar Braut Haarr 2013-06-18 09:03:56 UTC
gthumb seems to draw images with the wrong offset as evident in this screenshot: http://i.imgur.com/QD7GwaT.png

I went on #gtk+ and alex found the issue and made a patch:
http://paste.fedoraproject.org/19313/54557613/

I've compiled gthumb locally against latest GTK git and it works, as far as I can tell :-)
Comment 1 Vidar Braut Haarr 2013-06-18 09:04:29 UTC
Here's what alex said on IRC.

<alex> We're now actually using cairo when drawing child widgets
<alex> i.e. when drawing some subwidget we set an offset
<alex> in the cairo_t
<alex> so you can't just mash in the identity like that, as that will override said offset
<alex> not sure why it was there at all though
<alex>   cairo_translate (cr, 0.5, 0.5);
<alex> maybe to unset that
<alex> if so, it should use cairo_save/restore instead
Comment 2 Paolo Bacchilega 2013-06-18 17:58:29 UTC
Patch applied to master and gthumb-3-2. Thank you.