(In reply to comment #0)
> I'm still typing the current password and the spinner appears. It's
> distracting.
> 
> We should only check the password once someone has stopped typing for a second.
> After that, only show the spinner if the password check has taken more than two
> seconds.

Password check shouldn't take more than 2 seconds, so we can put the spinner out and password check may has same interval... is it ok?

Created attachment 249881 [details] [review]
remove spinner from the dialog

(In reply to comment #1)
> Password check shouldn't take more than 2 seconds, so we can put the spinner
> out and password check may has same interval... is it ok?

Hmmm, how do you know the password check shouldn't take more than two seconds?

I would suggest keeping this code, adding a timeout as allan suggests, because checking Enterprise passwords can arbitrarily take longer than that.

(In reply to comment #3)
> (In reply to comment #1)
> > Password check shouldn't take more than 2 seconds, so we can put the spinner
> > out and password check may has same interval... is it ok?
> 
> Hmmm, how do you know the password check shouldn't take more than two seconds?
> 
> I would suggest keeping this code, adding a timeout as allan suggests, because
> checking Enterprise passwords can arbitrarily take longer than that.

Good point, I wasn't thinking about the enterprise users, because password changing for enterprise accounts is currently disabled (see Bug 681866), isn't it? It looks like password changing for enterprise users isn't working yet according corresponding bugs, is it? So, in this case we don't need the spinner currently, do we?

So I guess we'll add all this code back once we fix the gotchas that prevent changing of Enterprise passwords? 

Your call. If that's the better approach code maintenance wise, then the patch makes sense.

(In reply to comment #5)
> So I guess we'll add all this code back once we fix the gotchas that prevent
> changing of Enterprise passwords? 

That's right.

> Your call. If that's the better approach code maintenance wise, then the patch
> makes sense.

I'd rather remove the spinner now due to the design changes which depends on, because we can't let the spinner at this place. We have to find the way, how to put the spinner inside GtkEntry (or put it at the different place), before enterprise password will be back.

Review of attachment 249881 [details] [review]:

Looks good.