GNOME Bugzilla – Bug 702309
Inconsistencies in presentation of avatar and user name
Last modified: 2013-10-02 20:27:16 UTC
Created attachment 246869 [details] screenshots Comparing the user list and the password entry view, there are three inconsistencies in the presentation of the avatar and user name: * Text size of the user name * Padding between avatar and user name * Radius of the border surrounding the avatar See the attached screenshots.
Which would you prefer in what mode?
The mockups have: * 20px bold for the font size and weight * 18px padding between avatar and user name * 3px radius for the border The one difference between the two is that they use different colors for the user name text: the user list uses #bfbfbf and the password screen uses white.
Created attachment 255587 [details] [review] A patch for the bug Changed the css file as specified in the bug
Created attachment 255588 [details] [review] made changes in gnome-shell.css file to fix some properties listed in https://bugzilla.gnome.org/show_bug.cgi?id=702309
Review of attachment 255588 [details] [review]: Thank you for your work. You need to have your full, real name in the patch as well as just an email and first name (Capitalise your name as well) A short meaningful commit message heading to explain you work A message with a link to the bug you are fixing Here is an example https://git.gnome.org/browse/gnome-shell/commit/?id=fb52a93a28f47220fce4341af667b2fdf52e1443
Comment on attachment 255588 [details] [review] made changes in gnome-shell.css file to fix some properties listed in https://bugzilla.gnome.org/show_bug.cgi?id=702309 >From 4bee0403e5fc379db53ba0a83372bd16fa73ebed Mon Sep 17 00:00:00 2001 >From: Yash Girdhar <yash.girdhar@gmail.com> >Date: Mon, 23 Sep 2013 23:37:20 +0530 >Subject: [PATCH] patch for bug 702309, made changes in gnome-shell.css file to fix https://bugzilla.gnome.org/show_bug.cgi?id=702309 > >--- > data/theme/gnome-shell.css | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/data/theme/gnome-shell.css b/data/theme/gnome-shell.css >index 15f91ef..49b954b 100644 >--- a/data/theme/gnome-shell.css >+++ b/data/theme/gnome-shell.css >@@ -2268,7 +2268,7 @@ StScrollBar StButton#vhandle:active { > > .framed-user-icon { > border: 2px solid #8b8b8b; >- border-radius: 5px; >+ border-radius: 3px; > background-size: contain; > } > >@@ -2326,7 +2326,7 @@ StScrollBar StButton#vhandle:active { > > .login-dialog-user-list-item .login-dialog-user-list-item-name { > font-size: 20pt; >- padding-left: 9px; >+ padding-left: 9px; > } > > .login-dialog-user-list:expanded .login-dialog-user-list-item { >@@ -2391,10 +2391,10 @@ StScrollBar StButton#vhandle:active { > } > > .login-dialog-username { >- font-size: 16pt; >+ font-size: 20px; > font-weight: bold; > text-align: left; >- padding-left: 15px; >+ padding-left: 18px; > text-shadow: black 0px 4px 3px 0px; > } > >@@ -2486,10 +2486,10 @@ StScrollBar StButton#vhandle:active { > } > > .user-widget-label { >- font-size: 16pt; >+ font-size: 20px; > font-weight: bold; > text-align: left; >- padding-left: 15px; >+ padding-left: 18px; > text-shadow: black 0px 4px 3px 0px; > } > >-- >1.8.3.1
Created attachment 255598 [details] [review] A patch for the bug 720309, changed gnome-shell.css made changes in gnome-shell.css file, to remove inconsistencies avatar and user name
Created attachment 256221 [details] [review] Modified the presentation of avatar and user name as per mock ups Changed the /data/theme/gnome-shell.css file to make the appropriate changes. 2 screens have been changed, the login screen that displays the list of users ( refers to js/gdm/loginDialog.js) and the 'Enter Password' screen ( refers to js/ui/unlockDialog.js ). Changes include : text size (and weight), padding between avatar and user name, and radius of avatar border. While modifying the avatar border in the first screen, it has been taken care of, that we also need to modify the radus of the outer box.
Review of attachment 256221 [details] [review]: When you change theme questions, it is commonly used a commit message like: "theme: modify the avatar and user name". As you can see commit message is presented in present verbal time and has to be 80 characters max. Then something like: Change the avatar and user name border radius, padding and text size to be consistent with mockups. Is enough. So the entire commit message: theme: modify the avatar and user name. Change the avatar and user name border radius, padding and text size to be consistent with mockups. https://bugzilla.gnome.org/show_bug.cgi?id=702309 ::: data/theme/gnome-shell.css @@ +2328,3 @@ + font-size: 20px; + font-weight: bold; + padding-left: 18px; Spaces instead of tabs please @@ +2343,3 @@ } + unwanted new line @@ +2490,3 @@ .user-widget-label { + font-size: 20px; + color:white; space instead of tabs please
Created attachment 256320 [details] [review] theme: modify the avatar and user name Change the avatar and user name border radius, padding and text size to be consistent with mockups.
Review of attachment 256320 [details] [review]: ok go ahead =)
Attachment 256320 [details] pushed as 51e016a - theme: modify the avatar and user name