After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702082 - seed_script_destroy: only unref source_url if it exists
seed_script_destroy: only unref source_url if it exists
Status: RESOLVED FIXED
Product: seed
Classification: Bindings
Component: libseed
git master
Other Linux
: Normal normal
: ---
Assigned To: seed-maint
seed-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-12 11:07 UTC by Emilio Pozuelo Monfort
Modified: 2013-06-13 08:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
seed_script_destroy: only unref source_url if it exists (832 bytes, patch)
2013-06-12 11:07 UTC, Emilio Pozuelo Monfort 		none Details | Review

Description Emilio Pozuelo Monfort 2013-06-12 11:07:19 UTC 
It's possible to create a script with a NULL source_url by passing NULL to seed_create_script, which is documented to be fine. So don't crash when destroying such a script.
Comment 1 Emilio Pozuelo Monfort 2013-06-12 11:07:51 UTC 
Created attachment 246607 [details] [review]
seed_script_destroy: only unref source_url if it exists

Fixes a crash when creating a script with a NULL source_url,
which is documented to be fine.
Comment 2 Alban Crequy 2013-06-12 12:38:20 UTC 
The patch looks good to me.
Comment 3 Alan Knowles 2013-06-13 08:46:22 UTC 
Thanks - committed