After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702061 - [MM 0.8] Cleanup old tests
[MM 0.8] Cleanup old tests
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: ModemManager
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: 702220
 
 
Reported: 2013-06-12 06:47 UTC by Aleksander Morgado
Modified: 2013-06-18 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Aleksander Morgado 2013-06-12 06:47:05 UTC 
The tests/ directory contains several programs that are still using the old MM interface:

 * Python scripts: commands to operate on the DBus API directly.
 * mm-test, mm-test-pppd-plugin: tester using a custom pppd plugin to simulate connections.

I'd vote for removing the python scripts, as the functionality was mainly to test the interfaces, and we already have that with 'mmcli'.

As for the tester with the pppd plugin, not sure what to do, should we also remove it or update it to use the new MM interface? Also, the pppd plugin is also currently being installed by default, which I don't think we should. Maybe add a new configure switch to explicitly enable it? Package distributors shouldn't care about that pppd plugin.
Comment 1 Dan Williams 2013-06-17 15:04:12 UTC 
I'm not sure it's worth keeping any of it.  If we wanted to keep the functionality, the mm-test.py script should be converted to libmm-glib anyway, plus to be really useful it would need to run dhclient as well, and since you don't necessarily want to muck up the routing table or DNS (which the distro default dhclient script would likely do) you'd need to have some custom stuff like NM does.  The script also doesn't serve as a user-runnable debug tool either.

I would say just junk the entire directory and we can rethink what kind of tests we want there.  mmcli replaces all the other python scripts, and most of mm-test.py too.
Comment 2 Aleksander Morgado 2013-06-18 14:32:43 UTC 
Done in git master now.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.