GNOME Bugzilla – Bug 702011
ovirt: Set host-subject when needed
Last modified: 2016-03-31 13:22:07 UTC
oVirt 3.2/libgovirt 0.1.0 can be used to know the host subject to use to validate the SSL certificate of a given VM. This host subject can be needed in some cases, for example when oVirt VMs migrated from one host to another. The BOXES_SPICE_HOST_SUBJECT environment variable hack is kept for now as this is still needed on older oVirt instances which don't provide the host subject in their REST API.
Created attachment 246523 [details] [review] ovirt: Set host-subject when needed
Review of attachment 246523 [details] [review]: Looks good otherwise. ::: configure.ac @@ +51,3 @@ AC_SUBST(GLIB_MIN_VERSION) GOBJECT_INTROSPECTION_MIN_VERSION=0.9.6 +GOVIRT_MIN_VERSION=0.1.0 If you could put that into a separate patch before pushing this change, that would be nice. ::: src/ovirt-machine.vala @@ +82,3 @@ switch (vm.display.type) { case Ovirt.VmDisplayType.SPICE: + var display = new SpiceDisplay (config, vm.display.address, (int)vm.display.port, coding-style nitpicks: * space after (int). * each arg on separate line. ::: src/spice-display.vala @@ +106,3 @@ // FIXME: remove this once libgovirt has proper support for // getting the SPICE host subject, it's useful for testing purpose // in the mean time This comment needs update.
Created attachment 246592 [details] [review] coding-style: Add space before (int)
Created attachment 246593 [details] [review] Update our govirt requirement to 0.1.0
Created attachment 246594 [details] [review] ovirt: Set host-subject when needed oVirt 3.2/libgovirt 0.1.0 can be used to know the host subject to use to validate the SSL certificate of a given VM. This host subject can be needed in some cases, for example when oVirt VMs migrated from one host to another. The BOXES_SPICE_HOST_SUBJECT environment variable hack is kept for now as this is still needed on older oVirt instances which don't provide the host subject in their REST API.
Review of attachment 246592 [details] [review]: ACK. ::: src/display-page.vala @@ +106,3 @@ window.get_window ().get_geometry (null, null, out width, null); + window.begin_move_drag ((int) button_down_button, + root_x + (int) ((button_down_x / (double)old_width) * width), missed one. :)
Review of attachment 246593 [details] [review]: ACK, assuming govirt 0.1.0 is either already released or will be before next 3.9.x release.
Review of attachment 246594 [details] [review]: ACK
Created attachment 246646 [details] [review] coding-style: Add space before (cast)
Review of attachment 246592 [details] [review]: ::: src/display-page.vala @@ +106,3 @@ window.get_window ().get_geometry (null, null, out width, null); + window.begin_move_drag ((int) button_down_button, + root_x + (int) ((button_down_x / (double)old_width) * width), if this is about the (double)..., note the commit log explicitly mentions (int).
Review of attachment 246646 [details] [review]: ACK
Attachment 246593 [details] pushed as 3416239 - Update our govirt requirement to 0.1.0 Attachment 246594 [details] pushed as 9ba2b56 - ovirt: Set host-subject when needed Attachment 246646 [details] pushed as 488f2fb - coding-style: Add space before (cast)