After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701695 - Fix glib critical at the end of non-express installs
Fix glib critical at the end of non-express installs
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-06 07:04 UTC by Christophe Fergeau
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix glib critical at the end of non-express installs (1.67 KB, patch)
2013-06-06 07:04 UTC, Christophe Fergeau
committed Details | Review

Description Christophe Fergeau 2013-06-06 07:04:07 UTC
At the end of installations, regardless of if they are express
installs or not, setup_post_install_domain_config is called.
It unconditionally tries to remove 'disk_file' from the VM configuration.
However, this member is only set for express installs, it's NULL
for non-express installs, so we get glib criticals in the console
when trying to use it as if it was non-NULL.
This commit avoids this issue by checking if it's NULL before using
it, as is done in most of unattended-installer.vala
Comment 1 Christophe Fergeau 2013-06-06 07:04:08 UTC
Created attachment 246129 [details] [review]
Fix glib critical at the end of non-express installs
Comment 2 Zeeshan Ali 2013-06-06 12:57:41 UTC
Review of attachment 246129 [details] [review]:

ACK
Comment 3 Christophe Fergeau 2013-06-06 13:32:25 UTC
Attachment 246129 [details] pushed as dcb1ed2 - Fix glib critical at the end of non-express installs