After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701460 - Don't set uri if the uri didn't change
Don't set uri if the uri didn't change
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks: 701380
 
 
Reported: 2013-06-02 11:46 UTC by Arnel Borja
Modified: 2013-06-02 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (892 bytes, patch)
2013-06-02 11:46 UTC, Arnel Borja 		committed Details | Review
Set uri on load only if the media changed (937 bytes, patch)
2013-06-02 14:43 UTC, Vadim Rutkovsky 		committed Details | Review

Description Arnel Borja 2013-06-02 11:46:48 UTC 
Created attachment 245848 [details] [review]
Patch

When the track is about to finish, the uri of the next uri is set to load it. But once it is loaded, the uri is set again, that sometimes causes a reload.

I attached a patch that checks if the uri didn't change before setting it.
Comment 1 Vadim Rutkovsky 2013-06-02 14:43:38 UTC 
Thanks, pushed

The following fix has been pushed:
9e35deb Set uri on load only if the media changed
Comment 2 Vadim Rutkovsky 2013-06-02 14:43:46 UTC 
Created attachment 245859 [details] [review]
Set uri on load only if the media changed

This will make sure that the current media will not be reloaded with the
metadata.