After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701345 - GtkHeaderBar: Make labels creation available privately
GtkHeaderBar: Make labels creation available privately
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-05-31 11:42 UTC by Bastien Nocera
Modified: 2013-06-14 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkHeaderBar: Make labels creation available privately (5.24 KB, patch)
2013-05-31 11:42 UTC, Bastien Nocera 		reviewed Details | Review
GtkHeaderBar: Make labels creation available privately (5.63 KB, patch)
2013-05-31 15:20 UTC, Bastien Nocera 		none Details | Review
GtkHeaderBar: Make labels creation available privately (5.64 KB, patch)
2013-06-11 11:09 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-05-31 11:42:54 UTC 
This will be used in the GtkMainToolbar widget
Comment 1 Bastien Nocera 2013-05-31 11:42:57 UTC 
Created attachment 245717 [details] [review]
GtkHeaderBar: Make labels creation available privately

So it can be reused in subclasses
Comment 2 Matthias Clasen 2013-05-31 13:41:43 UTC 
Review of attachment 245717 [details] [review]:

If we want to reuse it, it should have a bit more meaningful name, imo. 
gtk_header_bar_create_title_box or so
Comment 3 Bastien Nocera 2013-05-31 15:20:05 UTC 
Created attachment 245751 [details] [review]
GtkHeaderBar: Make labels creation available privately

So it can be reused in subclasses
Comment 4 Bastien Nocera 2013-06-11 11:09:41 UTC 
Created attachment 246495 [details] [review]
GtkHeaderBar: Make labels creation available privately

So it can be reused in subclasses
Comment 5 Matthias Clasen 2013-06-11 23:41:38 UTC 
Review of attachment 246495 [details] [review]:

ok
Comment 6 Bastien Nocera 2013-06-14 17:11:05 UTC 
Attachment 246495 [details] pushed as 8a45cb5 - GtkHeaderBar: Make labels creation available privately