GNOME Bugzilla – Bug 701316
rtspconnection: using g_pollable_stream_read and write breaks builds on Ubuntu and Debian stable
Last modified: 2013-05-31 12:12:54 UTC
Created attachment 245682 [details] [review] Replace g_pollable_stream_{read,write} with the functions that utility function calls When I build gst-plugins-base today, I got: gstrtspconnection.c: In function 'write_bytes': gstrtspconnection.c:866:5: error: implicit declaration of function 'g_pollable_stream_write' [-Werror=implicit-function-declaration] gstrtspconnection.c:866:5: error: nested extern declaration of 'g_pollable_stream_write' [-Werror=nested-externs] gstrtspconnection.c: In function 'fill_raw_bytes': gstrtspconnection.c:921:5: error: implicit declaration of function 'g_pollable_stream_read' [-Werror=implicit-function-declaration] gstrtspconnection.c:921:5: error: nested extern declaration of 'g_pollable_stream_read' [-Werror=nested-externs] cc1: all warnings being treated as errors The problem is because those two functions were added in GLib 2.34[1], which isn't available on Ubuntu 12.04 or Debian Wheezy. This patch just replaces those functions with the functions they call[2]. [1] https://developer.gnome.org/gio/2.36/gio-gpollableutils.html#g-pollable-stream-write [2] https://git.gnome.org/browse/glib/tree/gio/gpollableutils.c
commit 63961242dfe4a7624280a2e971b92245d9f421c6 Author: Brendan Long <b.long@cablelabs.com> Date: Thu May 30 16:00:35 2013 -0600 rtspconnection: remove functions added in GLib 2.34 g_pollable_stream_read and g_pollable_stream_write were added in GLib 2.34, but Ubuntu 12.04 and Debian Wheezy still use GLib 2.32. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=701316