After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701291 - When a song is paused, selecting a new song will just play the paused one
When a song is paused, selecting a new song will just play the paused one
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-30 15:44 UTC by Arnel Borja
Modified: 2013-05-30 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set player state to NULL when playlist is set (883 bytes, patch)
2013-05-30 15:46 UTC, Arnel Borja
committed Details | Review
Set player state to NULL when playlist is set (881 bytes, patch)
2013-05-30 16:41 UTC, Vadim Rutkovsky
committed Details | Review

Description Arnel Borja 2013-05-30 15:44:50 UTC
To reproduce:
1. Go to Songs view.
2. Select a song to play.
3. Click pause button in the toolbar.
4. Select a different song to play
5. The song in step 2 will play instead of the expected song in step 4.

To fix it, we just have to set the player's state to NULL when a new song is selected, which happens in player.setPlaylist().

I'll be attaching a patch that will do this.
Comment 1 Arnel Borja 2013-05-30 15:46:19 UTC
Created attachment 245657 [details] [review]
Set player state to NULL when playlist is set

This ensures that when a new item is selected in the view while the
player is in the PAUSED state, the new item will be played instead of
playing the paused item.
Comment 2 Vadim Rutkovsky 2013-05-30 16:38:59 UTC
Thanks, good catch!
Comment 3 Vadim Rutkovsky 2013-05-30 16:41:28 UTC
Good catch, thanks!

The following fix has been pushed:
6a29932 Set player state to NULL when playlist is set
Comment 4 Vadim Rutkovsky 2013-05-30 16:41:35 UTC
Created attachment 245665 [details] [review]
Set player state to NULL when playlist is set

This ensures that when a new item is selected in the view while the
player is in the PAUSED state, the new item will be played instead of
playing the paused item.