After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701276 - Update CSS to set a .Ring's stroke color and width
Update CSS to set a .Ring's stroke color and width
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
unspecified
Other All
: Normal normal
: ---
Assigned To: Joaquim Rocha
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-30 14:26 UTC by Joaquim Rocha
Modified: 2013-07-03 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wacom: Update CSS to set a .Ring's stroke color and width (821 bytes, patch)
2013-05-30 14:26 UTC, Joaquim Rocha
reviewed Details | Review
Screenshot of OSD for Cintiq 13HD without the CSS changes (131.53 KB, image/png)
2013-06-10 09:00 UTC, Joaquim Rocha
  Details
Screenshot of OSD for Cintiq 13HD with the CSS changes (136.28 KB, image/png)
2013-06-10 09:02 UTC, Joaquim Rocha
  Details

Description Joaquim Rocha 2013-05-30 14:26:35 UTC
This is needed for some tablets like the Cintiq 13HD which has buttons displayed on a wheel but the wheel is not a reactive one and will have buttons on top of it so it should only have a visible stroke and not be filled.
Comment 1 Joaquim Rocha 2013-05-30 14:26:37 UTC
Created attachment 245647 [details] [review]
wacom: Update CSS to set a .Ring's stroke color and width
Comment 2 Bastien Nocera 2013-06-04 16:11:46 UTC
Review of attachment 245647 [details] [review]:

Do you have a before and after screenshot?
Comment 3 Joaquim Rocha 2013-06-10 09:00:45 UTC
Created attachment 246386 [details]
Screenshot of OSD for Cintiq 13HD without the CSS changes
Comment 4 Joaquim Rocha 2013-06-10 09:02:53 UTC
Created attachment 246387 [details]
Screenshot of OSD for Cintiq 13HD with the CSS changes

Hey, I have attached the screenshots. You can see that without the CSS changes, it won't show the circles around the 4 buttons and the center one because these circles aren't buttons themselves but serve only for "visual guidance".

I hope we can push these changes.
Comment 5 Ping Cheng 2013-06-10 16:10:01 UTC
Thank you Joaquim for the nice update. There is a minor detail that is different from the actual device surface. The black square and dot on the lower two buttons are swapped. Please refer to http://www.wacom.com/products/pen-displays/cintiq/cintiq-13hd.
Comment 6 Joaquim Rocha 2013-06-11 09:18:29 UTC
Hi Ping,

Thank you for pointing this out. It is definitely a mistake in the SVG layout I created.

I have just sent a patch that fixes this to the linuxwacom-devel mailing list.
Comment 7 Joaquim Rocha 2013-07-03 13:24:46 UTC
Pushed after Bastien's approval on IRC.

commit f52dfede2ccbc20319e33e1fd6e7fb5caabc2348