After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701251 - Avoid build warnings for the Win32 GDK backend
Avoid build warnings for the Win32 GDK backend
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
3.9.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-05-30 08:09 UTC by Fan, Chun-wei
Modified: 2013-05-31 04:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Include config.h first (1.52 KB, patch)
2013-05-30 08:09 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2013-05-30 08:09:44 UTC 
Created attachment 245614 [details] [review]
Include config.h first

Hi,

There seems to be some build warnings for GDK-Win32 for some source files, due to the redefinition of _GDK_EXTERN as config.h is not included before the GDK headers
in these sources, gdkkeys-win32.c and gdktestutils-win32.c.  I have attached a simple patch to remedy these issues.

With blessings, thank you!
Comment 1 Matthias Clasen 2013-05-31 02:04:15 UTC 
Review of attachment 245614 [details] [review]:

Please push, with that comment removed. Thanks

::: gdk/win32/gdktestutils-win32.c
@@ +16,3 @@
  * License along with this library. If not, see <http://www.gnu.org/licenses/>.
  */
+#include "config.h" /* for _GDK_EXTERN */

I don't like these kinds of comments very much. 
And in particular for config.h, there's no need - it is a rule in gtk that config.h must always be included, and be included first.
Comment 2 Fan, Chun-wei 2013-05-31 04:07:06 UTC 
Review of attachment 245614 [details] [review]:

Hello Matthias,

The patch was pushed as 850d0e70 with your comments incorporated.  Thanks for your time and review.

I will close this bug shortly.

With blessings.