GNOME Bugzilla – Bug 701177
scripts: improve git-update.sh status message
Last modified: 2013-05-30 22:42:22 UTC
Created attachment 245525 [details] [review] Proposed patch By default when the script is about to exit (normally or due to an error), it checks whether $ERROR_LOG file exists. If the log file exists, the script prints a "Failures: " message prefix and dumps the log file to the output. Apparently the log file is always created and if the update/build is successful, the script finishes with a bit misleading "Failures: " message. An improvement provided with this change lets the log file to be created as needed, i.e. if there's an error message to be printed. If the file doesn't exists, the script prints a "Update done" message which clearly indicates success.
Thanks for the patch! Pushed into master: commit 527423fcd9a5b74b8bc3dfbae75871b9c0f87f7c Author: Krzysztof Konopko <krzysztof.konopko@gmail.com> Date: Tue May 28 23:34:54 2013 +0100 scripts: improve git-update.sh status message By default when the script is about to exit (normally or due to an error), it checks whether $ERROR_LOG file exists. If the log file exists, the script prints a "Failures: " message prefix and dumps the log file to the output. Apparently the log file is always created and if the update/build is successful, the script finishes with a bit misleading "Failures: " message. An improvement provided with this change lets the log file to be created as needed, i.e. if there's an error message to be printed. If the file doesn't exists, the script prints a "Update done" message which clearly indicates success. https://bugzilla.gnome.org/show_bug.cgi?id=701177