After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701151 - [MM 0.8] [review] broadband-bearer: don't create PDP context when using an existing one
[MM 0.8] [review] broadband-bearer: don't create PDP context when using an ex...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: ModemManager
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-05-28 20:06 UTC by Dan Williams
Modified: 2013-05-29 06:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-broadband-bearer-don-t-create-PDP-context-when-using.patch (4.11 KB, patch)
2013-05-28 20:07 UTC, Dan Williams 		committed Details | Review

Description Dan Williams 2013-05-28 20:06:45 UTC 
If the context is already defined, then we can just use it instead of calling +CGDCONT to create it again.  Modems don't like this, plus it's pointless.
Comment 1 Dan Williams 2013-05-28 20:07:24 UTC 
Created attachment 245488 [details] [review]
0001-broadband-bearer-don-t-create-PDP-context-when-using.patch
Comment 2 Marius Kotsbak 2013-05-28 21:31:57 UTC 
Patch seems to be working.
Comment 3 Aleksander Morgado 2013-05-29 06:58:36 UTC 
Review of attachment 245488 [details] [review]:

Minor typo, which I fixed before pushing.

::: src/mm-broadband-bearer.c
@@ +799,3 @@
     ctx->cid = g_variant_get_uint32 (result);
+
+    /* If there's already a PDP context defined, just iuse it */

Minor typo "iuse it"
Comment 4 Aleksander Morgado 2013-05-29 06:58:58 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.