After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700864 - error_selecting_folder_over_existing_file_dialog() will never display message
error_selecting_folder_over_existing_file_dialog() will never display message
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2013-05-22 22:18 UTC by Timothy Arceri
Modified: 2013-05-26 04:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix error dialog not being displayed (1.66 KB, patch)
2013-05-23 08:04 UTC, Timothy Arceri 		none Details | Review

Description Timothy Arceri 2013-05-22 22:18:31 UTC 
I came across this while trying to implement another warning message about long filenames.

The error message in error_selecting_folder_over_existing_file_dialog() will never be displayed as it passes NULL for GError in the call to error_dialog()
and the first thing error_dialog() does is makes sure error is not null before displaying anything.

error_dialog (GtkFileChooserDefault *impl,
	      const char            *msg,
	      GFile                 *file,
	      GError                *error)
{
  if (error)


FYI this code is all in gtkfilechooserdefault.c
Comment 1 Timothy Arceri 2013-05-23 08:04:42 UTC 
Created attachment 245105 [details] [review]
Fix error dialog not being displayed

This patch should cause the message to actually be displayed.