After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700854 - messageTray: Fix a stuck grab related to bubble notifications
messageTray: Fix a stuck grab related to bubble notifications
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-22 17:30 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-05-24 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Fix a stuck grab related to bubble notifications (2.53 KB, patch)
2013-05-22 17:30 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
messageTray: Fix a stuck grab related to bubble notifications (3.68 KB, patch)
2013-05-22 17:44 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-05-22 17:30:46 UTC 
If the user middle clicks on a summary item in the tray, we'll
try to grab null instead of an actor, which is wrong.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-05-22 17:30:48 UTC 
Created attachment 245076 [details] [review]
messageTray: Fix a stuck grab related to bubble notifications
Comment 2 Giovanni Campagna 2013-05-22 17:35:25 UTC 
Review of attachment 245076 [details] [review]:

::: js/ui/messageTray.js
@@ +2660,3 @@
+        // doesn't have a right-click menu, do nothing.
+        if (!child)
+            return;

Doesn't this leave us with set summaryBoxPointerItem, as well as connected signals to the source and summary item?
Comment 3 Giovanni Campagna 2013-05-22 17:35:26 UTC 
Review of attachment 245076 [details] [review]:

::: js/ui/messageTray.js
@@ +2660,3 @@
+        // doesn't have a right-click menu, do nothing.
+        if (!child)
+            return;

Doesn't this leave us with set summaryBoxPointerItem, as well as connected signals to the source and summary item?
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-05-22 17:44:47 UTC 
Created attachment 245077 [details] [review]
messageTray: Fix a stuck grab related to bubble notifications

If the user middle clicks on a summary item in the tray, we'll
try to grab null instead of an actor, which is wrong.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-05-23 16:02:46 UTC 
*** Bug 698883 has been marked as a duplicate of this bug. ***
Comment 6 Giovanni Campagna 2013-05-23 16:04:58 UTC 
Review of attachment 245077 [details] [review]:

Looks good.
Comment 7 Giovanni Campagna 2013-05-23 16:05:53 UTC 
Review of attachment 245077 [details] [review]:

Looks good.
Comment 8 Giovanni Campagna 2013-05-23 16:05:53 UTC 
Review of attachment 245077 [details] [review]:

Looks good.
Comment 9 Giovanni Campagna 2013-05-23 16:05:54 UTC 
Review of attachment 245077 [details] [review]:

Looks good.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-05-24 17:29:21 UTC 
Attachment 245077 [details] pushed as 991ed2d - messageTray: Fix a stuck grab related to bubble notifications