After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700842 - screencast: Fix return value in case of invalid file template
screencast: Fix return value in case of invalid file template
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-22 15:10 UTC by Florian Müllner
Modified: 2013-05-22 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screencast: Fix return value in case of invalid file template (1.63 KB, patch)
2013-05-22 15:11 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-05-22 15:10:57 UTC 
See patch.

Alternatively we could either change the out signature to (bms) (but maybe types seem fairly uncommon in general, and it's an API change) or change shell_recorder_record() to return an empty string rather than %NULL in the error case (not opposed to that, but it's a bit un-C-ish) ...
Comment 1 Florian Müllner 2013-05-22 15:11:00 UTC 
Created attachment 245047 [details] [review]
screencast: Fix return value in case of invalid file template

If we are passed an invalid file template, ShellRecorder.record()
will return a %NULL filename; as the Screencast DBus interface
expects a string return value, we cannot return the value unmodified
in that case.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-05-22 15:11:58 UTC 
Review of attachment 245047 [details] [review]:

OK.
Comment 3 Florian Müllner 2013-05-22 15:23:23 UTC 
Attachment 245047 [details] pushed as 374aee7 - screencast: Fix return value in case of invalid file template