After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700809 - Add a bunch of keywords for missing providers
Add a bunch of keywords for missing providers
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-21 20:25 UTC by Baptiste Mille-Mathias
Modified: 2013-08-23 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
online-accounts: Add a bunch of keywords for missing providers (1.27 KB, patch)
2013-05-21 20:25 UTC, Baptiste Mille-Mathias
reviewed Details | Review
online-accounts: Add a bunch of keywords for missing providers (1.21 KB, patch)
2013-05-23 14:19 UTC, Baptiste Mille-Mathias
committed Details | Review

Description Baptiste Mille-Mathias 2013-05-21 20:25:05 UTC
When searching for provider g-o-a applet is not displayed.
Comment 1 Baptiste Mille-Mathias 2013-05-21 20:25:07 UTC
Created attachment 244995 [details] [review]
online-accounts: Add a bunch of keywords for missing providers

Add keywords for Keyberos, Windows Live, Microsoft Exchange, SMTP and IMAP to ease search.
Comment 2 Matthias Clasen 2013-05-22 09:45:58 UTC
Review of attachment 244995 [details] [review]:

Many of these are trademarks that we can't really include, unfortunately
Comment 3 Bastien Nocera 2013-05-22 09:59:15 UTC
(In reply to comment #2)
> Review of attachment 244995 [details] [review]:
> 
> Many of these are trademarks that we can't really include, unfortunately

Why not?

(In reply to comment #1)
> Created an attachment (id=244995) [details] [review]
> online-accounts: Add a bunch of keywords for missing providers
> 
> Add keywords for Keyberos, Windows Live, Microsoft Exchange, SMTP and IMAP to
> ease search.

I doubt keyberos ranks highly amongst the searches. Kerberos maybe :)
Comment 4 Debarshi Ray 2013-05-22 12:52:26 UTC
(In reply to comment #2)
> Review of attachment 244995 [details] [review]:
> 
> Many of these are trademarks that we can't really include, unfortunately

We already have keywords for Facebook and Google, and so does Empathy. Is this a real concern? If it is then we will have to ask the SFLC to take a look at the terms and conditions.
Comment 5 Matthias Clasen 2013-05-23 10:24:29 UTC
https://bugs.freedesktop.org/show_bug.cgi?id=47157#c13
Comment 6 Debarshi Ray 2013-05-23 10:41:11 UTC
(In reply to comment #5)
> https://bugs.freedesktop.org/show_bug.cgi?id=47157#c13

Thanks. I will ask Karen to request the SFLC to look into it. We have been careful to examine the terms and conditions before adding support for a provider, so makes sense to watch for this angle too.
Comment 7 Baptiste Mille-Mathias 2013-05-23 14:19:53 UTC
Created attachment 245136 [details] [review]
online-accounts: Add a bunch of keywords for missing providers

Add keywords for Kerberos, SMTP and IMAP to ease search.
Comment 8 Baptiste Mille-Mathias 2013-05-23 14:23:23 UTC
Hi,

I removed Microsoft Exchange and Windows Live from my previous commit, and correct the Keyberos typo (Duh).

Out of curiosity why Google, Facebook, Twitter and Yahoo were accepted ? is there any change that occurred lately that changed the way we can use trademarked words ?
Comment 9 Jeremy Bicha 2013-05-23 14:37:48 UTC
Those concerned about trademarks in Keywords might want to look at the discussion at https://bugs.freedesktop.org/47157

In that case the LibreOffice developers did decide to go ahead and use the extra Keywords. See http://cgit.freedesktop.org/libreoffice/core/tree/sysui/desktop/menus/impress.desktop
Comment 10 Baptiste Mille-Mathias 2013-08-21 12:21:57 UTC
any news of that ?
Comment 11 Debarshi Ray 2013-08-21 12:43:02 UTC
Review of attachment 245136 [details] [review]:

Sorry about the delay. Looks good.
Comment 12 Debarshi Ray 2013-08-23 09:59:52 UTC
Comment on attachment 245136 [details] [review]
online-accounts: Add a bunch of keywords for missing providers

Committed. Thanks for the patch!