GNOME Bugzilla – Bug 700746
Use 'dumb quotes' rather than `really dumb quotes'
Last modified: 2013-05-21 14:40:16 UTC
This always annoys me. While adding some g_test_expect_message()s to NM I decided to fix it. This will almost certainly break some other peoples' use of g_test_expect_message(), but fortunately there aren't that many people using it yet, so now is the time to do it, and it's easy to fix in a way that works with or without this commit (by just skipping over the quotes in the pattern to be matched, eg "*assertion*foo > 0*failed*") Oh, I should probably fix the .po files before committing too. (Done with perl, so if everyone else hates this idea, it's not like I spent a ton of time on it :-)
Created attachment 244863 [details] [review] Use 'dumb quotes' rather than `really dumb quotes' Back in the far-off twentieth century, it was normal on unix workstations for U+0060 GRAVE ACCENT to be drawn as "‛" and for U+0027 APOSTROPHE to be drawn as "’". This led to the convention of using them as poor-man's ‛smart quotes’ in ASCII-only text. However, "'" is now universally drawn as a vertical line, and "`" at a 45-degree angle, making them an `odd couple' when used together. Unfortunately, there are lots of very old strings in glib, and also lots of new strings in which people have kept up the old tradition, perhaps entirely unaware that it used to not look stupid. Fix this by just using 'dumb quotes' everywhere.
Review of attachment 244863 [details] [review]: I am in favor of this, but something like this should probably get at least one other reviewer to +1.
yes, please. I hate the odd couple very much
Attachment 244863 [details] pushed as 4b94c08 - Use 'dumb quotes' rather than `really dumb quotes'