After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700732 - Edit->Modify->Hyperlink ignores type of existing link
Edit->Modify->Hyperlink ignores type of existing link
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.12.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 715111 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-05-20 16:58 UTC by dgt224
Modified: 2013-11-24 17:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description dgt224 2013-05-20 16:58:32 UTC
To reproduce: Create a hyperlink of any type other than Web Link. With the cell containing the link selected, choose Edit->Modify->Hyperlink. The dialog opens with type Web Link selected and with the Web Address field initialized to the address text of the existing link. Click on OK. The type of the hyperlink is changed to Web Link, as can be demonstrated by clicking on the link in the cell.
Comment 1 Andreas J. Guelzow 2013-05-20 18:37:26 UTC
in dialog-hyperlink.c we pretend to duplicate teh existing link:

	/* We are creating a new link since the existing link */
	/* may be used in many places. */
	/* We are duplicating it here rather than in an ok handler in case */
	/* The link is changed for a differnt cell in a different view. */
	state->link = g_object_new (gnm_hlink_url_get_type (), NULL);
	if (link == NULL)
		state->is_new = TRUE;
	else {
		state->is_new = FALSE;
		gnm_hlink_set_target (state->link, gnm_hlink_get_target (link));
		gnm_hlink_set_tip (state->link, gnm_hlink_get_tip (link));
	}

We are clearly ignoring the current type.
Comment 2 Andreas J. Guelzow 2013-05-23 02:03:11 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Andreas J. Guelzow 2013-11-24 17:13:05 UTC
*** Bug 715111 has been marked as a duplicate of this bug. ***