GNOME Bugzilla – Bug 700714
[PATCH] gtestutils: Ensure test subprocesses don't dump core
Last modified: 2013-05-20 18:08:29 UTC
Since we expect them to crash, let's not spam the system core dump collection (systemd, abrt). At the moment systemd is not very robust against programs crashing in loops. --- glib/gtestutils.c | 22 +++++++++++++++++++++- 1 files changed, 21 insertions(+), 1 deletions(-)
Created attachment 244776 [details] [review] don't dump core
Comment on attachment 244776 [details] [review] don't dump core Definitely agree with the sentiment. Not sure about what the right way to fix these is. Even with this patch, abrtd still seems to log that the crash happened; is there some way we can avoid that? (I guess we still need to set the core dump size to 0 as well, so we want *at least* this patch.) I needed to add "#include <sys/resource.h>" to make this compile on F18 >+ child_setup = trap_subprocess_child_setup; We control both processes, so you don't need to use a child setup function. Just do the setup from inside test_init() if g_test_subprocess() is TRUE (or just directly from the code that parses the --GTestSubprocess flag). And then in the future someone can add the equivalent Windows crash-dialog-suppressing code.
Created attachment 244847 [details] [review] 0001-gtestutils-Ensure-test-subprocesses-don-t-dump-core.patch
Created attachment 244848 [details] [review] don't dump core
Comment on attachment 244848 [details] [review] don't dump core yeah, that works, other than the fact that you forgot to git add gmessages-private.h
Thanks!