After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700595 - overviewControls: Move reactive flag to main actor
overviewControls: Move reactive flag to main actor
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-18 19:03 UTC by Florian Müllner
Modified: 2013-05-18 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
overviewControls: Move reactive flag to main actor (1.42 KB, patch)
2013-05-18 19:03 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2013-05-18 19:03:10 UTC
See patch.
Comment 1 Florian Müllner 2013-05-18 19:03:12 UTC
Created attachment 244648 [details] [review]
overviewControls: Move reactive flag to main actor

The main overview actor was made reactive to catch scroll-events
and propagate them; after some code shuffling, the actor that
catches scroll events ended up not being the same actor that's
supposed to propagate this, which broke using the scroll wheel
to switch workspaces.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-05-18 19:06:19 UTC
Review of attachment 244648 [details] [review]:

OK.
Comment 3 Florian Müllner 2013-05-18 19:10:34 UTC
Attachment 244648 [details] pushed as d658ec8 - overviewControls: Move reactive flag to main actor